CRD cleanup + helm client download retires + error classification by rohan-dassani · Pull Request #6291 · Azure/azure-cli-extensions

rohan-dassani · 2023-05-16T14:11:34Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

modified: src/connectedk8s/azext_connectedk8s/_params.py modified: src/connectedk8s/azext_connectedk8s/_utils.py modified: src/connectedk8s/azext_connectedk8s/custom.py new file: src/connectedk8s/azext_connectedk8s/patch-file.yaml

modified: src/connectedk8s/azext_connectedk8s/_utils.py modified: src/connectedk8s/azext_connectedk8s/custom.py

modified: src/connectedk8s/azext_connectedk8s/custom.py

modified: src/connectedk8s/azext_connectedk8s/commands.py modified: src/connectedk8s/azext_connectedk8s/custom.py new file: src/connectedk8s/azext_connectedk8s/tests/latest/recordings/test_forcedelete.yaml modified: src/connectedk8s/azext_connectedk8s/tests/latest/test_connectedk8s_scenario.py

modified: src/connectedk8s/azext_connectedk8s/custom.py renamed: src/connectedk8s/azext_connectedk8s/patch-file.yaml -> src/connectedk8s/azext_connectedk8s/remove_crd_finalizer.yaml modified: src/connectedk8s/azext_connectedk8s/tests/latest/recordings/test_forcedelete.yaml modified: src/connectedk8s/azext_connectedk8s/tests/latest/test_connectedk8s_scenario.py

modified: src/connectedk8s/azext_connectedk8s/tests/latest/test_connectedk8s_scenario.py

modified: src/connectedk8s/azext_connectedk8s/custom.py

modified: src/connectedk8s/setup.py

…ensions into force_delete_add

modified: src/connectedk8s/azext_connectedk8s/tests/latest/recordings/test_forcedelete.yaml

….com/rohan-dassani/azure-cli-extensions into timeout_in_crd_deletion_force_delete

modified: src/connectedk8s/azext_connectedk8s/tests/latest/recordings/test_forcedelete.yaml

modified: src/connectedk8s/setup.py

azure-client-tools-bot-prd · 2023-05-16T14:11:37Z

Hi @rohan-dassani,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

azure-client-tools-bot-prd · 2023-05-16T14:11:40Z

Hi @rohan-dassani,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

yonzhan · 2023-05-16T14:11:47Z

Thank you for your contribution! We will review the pull request and get back to you soon.

…_nightly_testing

modified: src/connectedk8s/setup.py

modified: src/connectedk8s/azext_connectedk8s/_utils.py

src/connectedk8s/HISTORY.rst

modified: src/connectedk8s/azext_connectedk8s/_constants.py modified: src/connectedk8s/azext_connectedk8s/_utils.py

modified: src/connectedk8s/azext_connectedk8s/custom.py

sirireddy12 · 2023-05-19T07:11:22Z

src/connectedk8s/azext_connectedk8s/_constants.py

@@ -212,6 +212,9 @@
 Cluster_Diagnostic_Checks_Job_Log_Save_Failed = 'Failed to save cluster diagnostic checks job log'
 # Diagnostic Results Name
 Outbound_Connectivity_Check_Result_String = "Outbound Network Connectivity Result:"


I think this is a little confusing. Let's name the tests as "Outbound_Connectivity_Check_For_Onboarding" and "Outbound_Connectivity_Check_For_ClusterConnect" at all places to make it clear in the code as well

Same comment for logs as well which we're appending in the arc_diagnostic_logs folder

Yeah but OBO is not the only endpoint for cluster connect right , so if any other endpoint required for cluster connect fails then the log will not give the right impression to us and to the user.

sirireddy12 · 2023-05-19T07:15:45Z

src/connectedk8s/azext_connectedk8s/_utils.py

        # Validating if outbound connectiivty is working or not and displaying proper result
        if(outbound_connectivity_response != "000"):
+            # since connectivity to obo endpoint is required only for cluster connect feature , we only give out a warning if connectivity to obo endpoint is not present
+            if obo_check_response_code == "000":


Can't we have this condition outside of the parent if check? That way we keep it independent and will be easy to increase the list of endpoints in each category easily in future

The reason for keeping this inside the if condition was , that supposing that the outbound connectivity isnt there to any endpoint , it will still give out the warning about obo endpoint and then it will say outbound connectivity fail when it checks the mcr endpoint.

So i thought if mcr itself fails , then pointing to obo specifically doesnt make sense and the user should look into all the endpoint network requirements document. And if mcr connectivity is there than pointing out if some specific endpoint is not listed makes more sense.

modified: src/connectedk8s/azext_connectedk8s/_precheckutils.py modified: src/connectedk8s/azext_connectedk8s/_utils.py

sirireddy12

lgtm

src/connectedk8s/azext_connectedk8s/_utils.py

modified: src/connectedk8s/azext_connectedk8s/_utils.py

azclibot · 2023-05-22T10:16:35Z

[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=57185&view=results

rohan-dassani and others added 30 commits August 26, 2022 13:16

modified: src/connectedk8s/azext_connectedk8s/custom.py

e275558

modified: src/connectedk8s/azext_connectedk8s/custom.py

8c89fc3

modified: src/connectedk8s/azext_connectedk8s/_constants.py

11c2f90

modified: src/connectedk8s/azext_connectedk8s/_utils.py modified: src/connectedk8s/azext_connectedk8s/custom.py

modified: src/connectedk8s/azext_connectedk8s/_constants.py

fb57d0c

modified: src/connectedk8s/azext_connectedk8s/custom.py

9d2317c

modified: src/connectedk8s/azext_connectedk8s/custom.py

d684639

modified: src/connectedk8s/azext_connectedk8s/custom.py

866e916

Merge branch 'Azure:main' into force_delete_add

2202cd3

modified: src/connectedk8s/azext_connectedk8s/custom.py

76800dd

modified: src/connectedk8s/azext_connectedk8s/custom.py

cd46fbc

modified: src/connectedk8s/azext_connectedk8s/_utils.py

b46d055

modified: src/connectedk8s/azext_connectedk8s/custom.py

modified: src/connectedk8s/azext_connectedk8s/custom.py

474e2ec

modified: src/connectedk8s/azext_connectedk8s/custom.py

0190574

modified: src/connectedk8s/azext_connectedk8s/custom.py

6e893c4

modified: src/connectedk8s/azext_connectedk8s/custom.py

a639010

modified: src/connectedk8s/azext_connectedk8s/tests/latest/test_connectedk8s_scenario.py

modified: src/connectedk8s/azext_connectedk8s/_params.py

ba70771

modified: src/connectedk8s/azext_connectedk8s/custom.py

modified: src/connectedk8s/HISTORY.rst

fda625c

modified: src/connectedk8s/setup.py

modified: src/connectedk8s/HISTORY.rst

088d5e9

Merge branch 'main' of https://github.com/rohan-dassani/azure-cli-ext…

3062720

…ensions into force_delete_add

modified: src/connectedk8s/azext_connectedk8s/custom.py

944c706

modified: src/connectedk8s/azext_connectedk8s/tests/latest/recordings/test_forcedelete.yaml

modified: src/connectedk8s/azext_connectedk8s/custom.py

6aa9077

modified: src/connectedk8s/azext_connectedk8s/tests/latest/recordings/test_forcedelete.yaml

Merge branch 'timeout_in_crd_deletion_force_delete' of https://github…

238de24

….com/rohan-dassani/azure-cli-extensions into timeout_in_crd_deletion_force_delete

modified: src/connectedk8s/azext_connectedk8s/custom.py

7ff4202

modified: src/connectedk8s/azext_connectedk8s/custom.py

d4ea462

modified: src/connectedk8s/azext_connectedk8s/custom.py

810dd10

modified: src/connectedk8s/azext_connectedk8s/tests/latest/recordings/test_forcedelete.yaml

modified: src/connectedk8s/HISTORY.rst

2110301

modified: src/connectedk8s/setup.py

modified: src/connectedk8s/HISTORY.rst

7741186

azure-client-tools-bot-prd bot added this to the June 2023 (2023-07-04) milestone May 16, 2023

rohan-dassani added 2 commits May 16, 2023 19:43

Merge https://github.com/Azure/azure-cli-extensions into connectedk8s…

5b897e6

…_nightly_testing

modified: src/connectedk8s/HISTORY.rst

5768727

modified: src/connectedk8s/setup.py

rohan-dassani marked this pull request as draft May 16, 2023 14:19

yonzhan requested review from yanzhudd and zhoxing-ms May 16, 2023 16:01

yonzhan assigned zhoxing-ms May 16, 2023

modified: src/connectedk8s/azext_connectedk8s/_precheckutils.py

b7294f1

modified: src/connectedk8s/azext_connectedk8s/_utils.py

sirireddy12 reviewed May 17, 2023

View reviewed changes

src/connectedk8s/HISTORY.rst Outdated Show resolved Hide resolved

rohan-dassani added 3 commits May 18, 2023 11:38

modified: src/connectedk8s/HISTORY.rst

5984a7d

modified: src/connectedk8s/azext_connectedk8s/_constants.py modified: src/connectedk8s/azext_connectedk8s/_utils.py

modified: src/connectedk8s/azext_connectedk8s/custom.py

b2e2c3a

modified: src/connectedk8s/azext_connectedk8s/_utils.py

109b8ad

modified: src/connectedk8s/azext_connectedk8s/custom.py

sirireddy12 reviewed May 19, 2023

View reviewed changes

rohan-dassani added 4 commits May 19, 2023 14:04

modified: src/connectedk8s/azext_connectedk8s/_constants.py

e888a00

modified: src/connectedk8s/azext_connectedk8s/_constants.py

8240c57

modified: src/connectedk8s/azext_connectedk8s/_precheckutils.py modified: src/connectedk8s/azext_connectedk8s/_utils.py

modified: src/connectedk8s/HISTORY.rst

64cd63e

modified: src/connectedk8s/azext_connectedk8s/_constants.py

aa87e3f

rohan-dassani changed the title ~~OBO changes + CRD cleanup + helm client download retires~~ CRD cleanup + helm client download retires + error classification May 19, 2023

sirireddy12 approved these changes May 19, 2023

View reviewed changes

rohan-dassani marked this pull request as ready for review May 19, 2023 09:59

zhoxing-ms approved these changes May 19, 2023

View reviewed changes

zhoxing-ms reviewed May 19, 2023

View reviewed changes

src/connectedk8s/azext_connectedk8s/_utils.py Outdated Show resolved Hide resolved

modified: src/connectedk8s/azext_connectedk8s/_constants.py

612d96b

modified: src/connectedk8s/azext_connectedk8s/_utils.py

zhoxing-ms approved these changes May 22, 2023

View reviewed changes

zhoxing-ms merged commit 129d446 into Azure:main May 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CRD cleanup + helm client download retires + error classification#6291

CRD cleanup + helm client download retires + error classification#6291
zhoxing-ms merged 116 commits intoAzure:mainfrom
rohan-dassani:connectedk8s_nightly_testing

rohan-dassani commented May 16, 2023

Uh oh!

azure-client-tools-bot-prd bot commented May 16, 2023

Uh oh!

azure-client-tools-bot-prd bot commented May 16, 2023

Uh oh!

yonzhan commented May 16, 2023

Uh oh!

Uh oh!

sirireddy12 May 19, 2023 •

edited

Loading

Uh oh!

sirireddy12 May 19, 2023

Uh oh!

rohan-dassani May 19, 2023

Uh oh!

sirireddy12 May 19, 2023

Uh oh!

rohan-dassani May 19, 2023

Uh oh!

sirireddy12 left a comment

Uh oh!

Uh oh!

azclibot commented May 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

rohan-dassani commented May 16, 2023

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented May 16, 2023

Uh oh!

azure-client-tools-bot-prd bot commented May 16, 2023

Uh oh!

yonzhan commented May 16, 2023

Uh oh!

Uh oh!

sirireddy12 May 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sirireddy12 May 19, 2023

Choose a reason for hiding this comment

Uh oh!

rohan-dassani May 19, 2023

Choose a reason for hiding this comment

Uh oh!

sirireddy12 May 19, 2023

Choose a reason for hiding this comment

Uh oh!

rohan-dassani May 19, 2023

Choose a reason for hiding this comment

Uh oh!

sirireddy12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

azclibot commented May 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sirireddy12 May 19, 2023 •

edited

Loading